Allow for multiple applications to share a Redis DB #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelolx
reviewed
Aug 23, 2022
TALlama
force-pushed
the
feature/multi-app-same-db
branch
from
e2017f1
to
b3b0860
Compare
|
@marcelolx added. |
|
Also heads up that the link to the commit message style guide on CONTRIBUTING.md is broken |
|
Thanks @TALlama! I'll look into updating the contributing guide. Added the PR to my list to review, as soon as I have time I'll take a final look |
Most other keys are centralized in `SidekiqScheduler::RedisManager` as class methods. This does the same with the "schedules" key.
Most other keys are centralized in `SidekiqScheduler::RedisManager` as class methods. This does the same with the "schedules_changed" key.
Adds the ability to set a `key_prefix` which will be prepended to all Redis keys. This allows multiple applications to keep their schedules in the same Redis database without clobbering each other.
TALlama
force-pushed
the
feature/multi-app-same-db
branch
from
b3b0860
to
119d591
Compare
|
Thanks @TALlama! I have to fix the CI to run the tests, but from what I remember the last time it did pass, so probably nothing is broken. Thank you for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #400
Adds the ability to set a
key_prefixwhich will be prepended to all Redis keys. This allows multiple applications to keep their schedules in the same Redis database without clobbering each other.This change does not affect the runtime of the RSpec suite, but allows for the use case mentioned. Doing the first two commits without the last one would allow for monkey patches, but if we could do the whole thing that would be great.