fix: prevent sidekiq_options from overriding ActiveJob queue settings #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @marcelolx ! Was hoping to bump this PR for review :) We would love to get it merged so we can get off our internal fork. |
|
Hey @RickCSong, I have cherry-picked it into the v3-stable branch, please point your Gemfile to that branch until a new release is made (I have some work to merge to that branch before creating a new release). |
|
@RickCSong, 3.2.0 has been released with the fix for this https://github.com/moove-it/sidekiq-scheduler/blob/v3-stable/CHANGELOG.md I've also released v4.0.0.alpha1 https://github.com/moove-it/sidekiq-scheduler/blob/v4.0.0.alpha1/CHANGELOG.md to be tested by the community (final release will come later after we're sure we haven't broken anything). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #303