Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix redis exists deprecation warning" #346

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

marcelolx
Copy link
Member

Reverts #335

Ref: #345

@marcelolx
Copy link
Member Author

@juan-apa Just to give you more context, I think the best option to fix #345 is if we check the redis version and then chose which method call, but mock_redis only implements exists? on v0.24 https://github.com/sds/mock_redis/releases/tag/v0.24.0 so we will need to upgrade since we are using v0.19 and between this bumps support for some ruby versions was dropped which I think we should drop too since ruby 2.4 already reached end of life a year ago.

@marcelolx marcelolx merged commit 21dfdce into master Aug 9, 2021
@marcelolx marcelolx deleted the revert-335-patch-1 branch August 9, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants