Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix specs with Sidekiq >= 6.2 #339

Merged
merged 1 commit into from May 14, 2021
Merged

Fix specs with Sidekiq >= 6.2 #339

merged 1 commit into from May 14, 2021

Conversation

marcelolx
Copy link
Member

@marcelolx marcelolx commented May 12, 2021 •
edited

Since sidekiq/sidekiq#4804 sidekiq requires to be configured explicitly with a rack session.

@marcelolx marcelolx requested a review from snmgian May 12, 2021 23:46
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 97.973% when pulling 8980182 on fix/web-specs-adding-rack-session into 41990aa on master.

@marcelolx marcelolx mentioned this pull request May 13, 2021
Merged
elpic
elpic approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@elpic elpic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelolx marcelolx merged commit e67a778 into master May 14, 2021
@marcelolx marcelolx deleted the fix/web-specs-adding-rack-session branch May 14, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpic elpic elpic approved these changes

@snmgian snmgian Awaiting requested review from snmgian

Assignees

@marcelolx marcelolx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcelolx @coveralls @elpic