-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix redis-rb v4.6.0 pipelining depreciation #309
Fix redis-rb v4.6.0 pipelining depreciation #309
Conversation
thanks for this patch @d1ceward 👌🏼 @ondrejbartas do you think we can merge this one and prepare a release? Thank you so much in advance! |
So is it time to start considering that this repo isn't actively maintained anymore and so we should look at starting a fork where we can add some new maintainers? |
@boushley yes please. I am holding off a release until this dependency can be resolved. I don't much fancy spamming our production logs with this deprecation notice. |
I agree it would be really helpful to publish a new release. Similar issues, like #288, have been fixed in |
Thanks for this, I am using this branch |
Any chance to cut a new release? |
I believe we're planning to migrate to: https://github.com/Moove-it/sidekiq-scheduler as it seems to have active maintainers. |
Hum, I understand, but I feel just fine with this gem, does the trick for my needs and would love to spare the migration time :p @ondrejbartas , any chance for a new rubygems release? |
@boushley thanks, we might do the same. It looks like a fairly easy migration path. |
@ondrejbartas thanks for the work. |
@AndreiMotinga that was released as 1.3.0 https://github.com/ondrejbartas/sidekiq-cron/blob/master/Changes.md#130 |
Hi,
This is a small fix for the depreciation alert that appeared with version 4.6.0 of redis-rb which can pollute the logs quite a bit.
(cf. https://github.com/redis/redis-rb/blob/master/CHANGELOG.md#460)
Example of the depreciation message