Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redis-rb v4.6.0 pipelining depreciation #309

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Fix redis-rb v4.6.0 pipelining depreciation #309

merged 1 commit into from
Apr 6, 2022

Conversation

d1ceward
Copy link
Contributor

@d1ceward d1ceward commented Feb 4, 2022

Hi,
This is a small fix for the depreciation alert that appeared with version 4.6.0 of redis-rb which can pollute the logs quite a bit.
(cf. https://github.com/redis/redis-rb/blob/master/CHANGELOG.md#460)

Example of the depreciation message
image

kofiasare added a commit to kofiasare/sidekiq-cron that referenced this pull request Feb 4, 2022
@agramichael agramichael mentioned this pull request Feb 8, 2022
@markets
Copy link
Member

markets commented Feb 8, 2022

thanks for this patch @d1ceward 👌🏼

@ondrejbartas do you think we can merge this one and prepare a release? Thank you so much in advance!

@boushley
Copy link

So is it time to start considering that this repo isn't actively maintained anymore and so we should look at starting a fork where we can add some new maintainers?

@jaedb
Copy link

jaedb commented Feb 14, 2022

@boushley yes please. I am holding off a release until this dependency can be resolved. I don't much fancy spamming our production logs with this deprecation notice.

@markets
Copy link
Member

markets commented Feb 14, 2022

I agree it would be really helpful to publish a new release.

Similar issues, like #288, have been fixed in master branch (full diff: v1.2.0...master), but still not pushed to RubyGems.

@mathieujobin
Copy link

Thanks for this, I am using this branch

@qortex
Copy link

qortex commented Mar 20, 2022

Any chance to cut a new release?

@boushley
Copy link

I believe we're planning to migrate to: https://github.com/Moove-it/sidekiq-scheduler as it seems to have active maintainers.

@qortex
Copy link

qortex commented Mar 21, 2022

Hum, I understand, but I feel just fine with this gem, does the trick for my needs and would love to spare the migration time :p

@ondrejbartas , any chance for a new rubygems release?

@ludo
Copy link

ludo commented Mar 21, 2022

@boushley thanks, we might do the same. It looks like a fairly easy migration path. sidekiq-cron has served us well. I know priorities change and I can understand that sidekiq-cron is not the highest priority for the maintainers :) C'est la vie!

@ondrejbartas ondrejbartas merged commit 31cb295 into sidekiq-cron:master Apr 6, 2022
@AndreiMotinga
Copy link

@ondrejbartas thanks for the work.
any chance you planning on cutting a new release any time soon?

@markets
Copy link
Member

markets commented Apr 7, 2022

@AndreiMotinga that was released as 1.3.0 https://github.com/ondrejbartas/sidekiq-cron/blob/master/Changes.md#130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet