Redis#exists(key) Warning from redis 4.2.0

[majksner]

sidekiq/sidekiq#4591

Changes needed:

https://github.com/ondrejbartas/sidekiq-cron/blob/master/lib/sidekiq/cron/job.rb#L464

- conn.zadd(job_enqueued_key, time.to_f.to_s, formated_last_time(time).to_s) unless conn.exists(job_enqueued_key)
+ conn.zadd(job_enqueued_key, time.to_f.to_s, formated_last_time(time).to_s) unless conn.exists?(job_enqueued_key)

https://github.com/ondrejbartas/sidekiq-cron/blob/master/lib/sidekiq/cron/job.rb#L543

- out = conn.exists redis_key name
+ out = conn.exists? redis_key name

[jankeesvw]

I'm also seeing this deprecation warning, can I do anything to fix this?

[majksner]

@jankeesvw Until it's fixed you can fork library and change what I have above and point your Gemfile to your github repository.

[MikeRogers0]

@jankeesvw I've just made a PR, you can update your Gemfile to track my bugfix branch if you'd like (Though as a warning, CI on the PR isn't passing):

gem 'sidekiq-cron', github: 'MikeRogers0/sidekiq-cron', branch: 'bug/fix-redis-warning'

:)

[cbaudouinjr]

Any updates on getting this PR to pass CI/get merged in? I can help if needed!

[botularius]

Any news on this?

[hebbo]

Keeping an eye here also in search of a fix. Thanks!

[MikeRogers0]

I sent an email to @ondrejbartas to see if he's ok & will merge my PR with the fix to this, I'm guessing he might have notifications turned off & hasn't seen this thread yet.

[h0jeZvgoxFepBQ2C]

Ping @ondrejbartas

[tleish]

Why was this ticket closed when it's still an issue with the released gem?

[olegykz]

@tleish I've created #318 to finally get rid of the deprecation warning