Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sidekiq before Redis 5.0 launch #456

Closed
cbaudouinjr opened this issue Dec 13, 2020 · 1 comment · Fixed by #461
Closed

Update Sidekiq before Redis 5.0 launch #456

cbaudouinjr opened this issue Dec 13, 2020 · 1 comment · Fixed by #461
Assignees
Labels
2.2 the next rodeo dependencies Pull requests that update a dependency file
Projects

Comments

@cbaudouinjr
Copy link
Member

Currently getting a warning in our logs that highlights a feature of Redis that is being removed in Redis 5.0

Redis#exists(key) will return an Integer in redis-rb 4.3. "exists?" returns a boolean, you should use it instead. To opt-in to the new behavior now you can set Redis.exists_returns_integer = true. To disable this message and keep the current (boolean) behaviour of "exists" you can set "Redis.exists_returns_integer = false", but this option will be removed in 5.0. (/app/vendor/bundle/ruby/2.6.0/gems/sidekiq-6.0.7/lib/sidekiq/launcher.rb:160:in "block (2 levels) in ❤")

@cbaudouinjr cbaudouinjr added dependencies Pull requests that update a dependency file 2.2 the next rodeo labels Dec 13, 2020
@cbaudouinjr cbaudouinjr added this to To do in v2.2.0 via automation Dec 13, 2020
@cbaudouinjr cbaudouinjr moved this from To do to In progress in v2.2.0 Dec 15, 2020
@cbaudouinjr cbaudouinjr self-assigned this Dec 22, 2020
@cbaudouinjr
Copy link
Member Author

cbaudouinjr commented Dec 22, 2020

Blocked by #462. Also worth noting that while this does resolve a bulk of the warnings, we use a sidekick gem 😉 sidekiq-cron that still needs to be updated. See sidekiq-cron/sidekiq-cron#286

@cbaudouinjr cbaudouinjr moved this from In progress to To do in v2.2.0 Dec 22, 2020
@cbaudouinjr cbaudouinjr linked a pull request Jan 27, 2021 that will close this issue
@cbaudouinjr cbaudouinjr moved this from To do to In progress in v2.2.0 Jan 27, 2021
@cbaudouinjr cbaudouinjr moved this from In progress to Waiting for Review in v2.2.0 Jan 27, 2021
v2.2.0 automation moved this from Waiting for Review to Done Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.2 the next rodeo dependencies Pull requests that update a dependency file
Projects
No open projects
v2.2.0
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant