Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ctx.error with fatal options should work with the async loader fn #580

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

evenchange4
Copy link
Contributor

…unction

What kind of change does this PR introduce?

Did you add tests(unit,e2e) for your changes?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

@evenchange4 evenchange4 changed the title fix: ctx.error with fatal options should work with the async loader f… fix: ctx.error with fatal options should work with the async loader fn Mar 20, 2024
Copy link
Contributor

@liximomo liximomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@liximomo liximomo merged commit 1b7d597 into shuvijs:main Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants