fix: compile module before redirecting to it #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tom.ww <tom.ww@binance.com>
andy-yuanchang
force-pushed
the
fix-on-demand-redirect
branch
from
ea78167
to
afe9ba5
Compare
andy-yuanchang
force-pushed
the
fix-on-demand-redirect
branch
from
afe9ba5
to
22d9a1c
Compare
Co-authored-by: Tom <21499747@qq.com>
liximomo
force-pushed
the
main
branch
7 times, most recently
from
da730dc
to
b36ef15
Compare
liximomo
force-pushed
the
main
branch
2 times, most recently
from
909ee46
to
75efdce
Compare
liximomo
force-pushed
the
main
branch
14 times, most recently
from
1cc168d
to
528cdee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests(unit,e2e) for your changes?
no
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
no
At beginning, we planned to activate module in the beforeResolve.
Ideally, the HTML document should be sent after beforeResolve done, but the document will be sent before the beforeResolve finished. Even though building the document until page has compiled, the route is wrong because beforeResolve has finished after the document sent still.