Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mini css loader upgrade #146

Merged
merged 1 commit into from Mar 24, 2021
Merged

mini css loader upgrade #146

merged 1 commit into from Mar 24, 2021

Conversation

li2568261
Copy link
Contributor

fix the mini-css-extract-plugin publicPath:auto bug

@liximomo
Copy link
Contributor

Can you give a detailed describe of the bug?

@li2568261
Copy link
Contributor Author

@li2568261
Copy link
Contributor Author

module federation build error.

@li2568261
Copy link
Contributor Author

Error: ../../node_modules/monaco-editor/esm/vs/base/browser/ui/codicons/codicon/codicon.css
Error: Automatic publicPath is not supported in this browser
at runMicrotasks ()
at /Users/user/Desktop/workspaces/mono/node_modules/shuvi/lib/cli/apis/build.js:34:19
at Generator.next ()
at fulfilled (/Users/user/Desktop/workspaces/mono/node_modules/shuvi/lib/cli/apis/build.js:5:58)

@ZhengYuTay
Copy link
Contributor

ZhengYuTay commented Mar 24, 2021

@liximomo, yea so this bug originated from mini-css-extract-plugin when publicPath is set to auto, it throw error when building the app.

The solution is just update the package.

@liximomo liximomo merged commit 4889380 into shuvijs:master Mar 24, 2021
@liximomo liximomo deleted the cssLoaderBug branch March 24, 2021 05:34
liximomo pushed a commit that referenced this pull request Jun 11, 2022
Co-authored-by: lee-l <lee.l@binance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants