fix(images): fix js error when using image references

In some circumstances, on a reference style image, the last capturing group is ignored, which causes the fucntion argument to return the number of matches instead of a string (or undefined). Checking if the title parameter is a string ensures that the title parameter is actually something that was caught by the regex and not some metadata. Closes #585
showdownjs · Sep 14, 2018 · b0d475f · b0d475f
1 parent 63763b1
commit b0d475f
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 8 deletions.
diff --git a/dist/showdown.js b/dist/showdown.js
diff --git a/dist/showdown.js.map b/dist/showdown.js.map
diff --git a/dist/showdown.min.js b/dist/showdown.min.js
diff --git a/dist/showdown.min.js.map b/dist/showdown.min.js.map
diff --git a/src/subParsers/makehtml/images.js b/src/subParsers/makehtml/images.js
@@ -61,7 +61,7 @@ showdown.subParser('makehtml.images', function (text, options, globals) {
     url = url.replace(showdown.helper.regexes.asteriskDashAndColon, showdown.helper.escapeCharactersCallback);
     var result = '<img src="' + url + '" alt="' + altText + '"';
 
-    if (title) {
+    if (title && showdown.helper.isString(title)) {
       title = title
         .replace(/"/g, '&quot;')
       //title = showdown.helper.escapeCharacters(title, '*_', false);

diff --git a/test/functional/makehtml/cases/issues/#585.error-when-using-image-references.html b/test/functional/makehtml/cases/issues/#585.error-when-using-image-references.html
@@ -1,3 +1 @@
-[![the-image]]
-
-[the-image]: http://example.com/foo.png
+<p>[<img src="http://example.com/foo.png" alt="the-image" />]</p>
diff --git a/test/functional/makehtml/cases/issues/#585.error-when-using-image-references.md b/test/functional/makehtml/cases/issues/#585.error-when-using-image-references.md
@@ -0,0 +1,3 @@
+[![the-image]]
+
+[the-image]: http://example.com/foo.png