CassandraSinkCluster: pull routing logic into separate function #1631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CassandraSinkCluster has a really large
send_message
method, it should be broken down into multiple smaller functions.To start with lets pull out the request routing logic into a
route_requests
method, this matches a function of the same name and purpose inKafkaSinkCluster
.The
send_message
function is also really poorly named but that should be addressed by moving the contents intoTransform::transform
which should occur in another PR to keep scope down.The "Files changed" diff is very confusing and doesnt properly show the moving of the routing logic.
If you look at the individual commits you can see that the routing logic is removed and then readded as a separate function.
I recommend pasting the large chunk of logic that is removed and readded into a diff tool to verify the logic remains identical.