Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pretty assert #1624

Merged
merged 2 commits into from
May 21, 2024
Merged

pretty assert #1624

merged 2 commits into from
May 21, 2024

Conversation

conorbros
Copy link
Member

Seeing if there is interest in using this library. An example can be seen in the logs.

@rukai
Copy link
Member

rukai commented May 14, 2024

Woah, I love this!
Lets set it to a dev-dependency instead of regular dependency and land this!

For the review who sees this after the intentional failure is removed, the assert_eq now has colored highlighting and looks like this:
image

Copy link

codspeed-hq bot commented May 17, 2024

CodSpeed Performance Report

Merging #1624 will improve performances by 10.94%

Comparing conorbros:pretty-assert (1c6244b) with main (c1331f8)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main conorbros:pretty-assert Change
encode_system.local_result_v5_no_compression 491.1 µs 442.7 µs +10.94%

@rukai
Copy link
Member

rukai commented May 17, 2024

Is the test failure intentional?

Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

shotover/Cargo.toml Outdated Show resolved Hide resolved
test-helpers/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed some issues

@conorbros conorbros merged commit 0461a88 into shotover:main May 21, 2024
41 checks passed
@conorbros conorbros deleted the pretty-assert branch May 21, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants