Vector tests #1570
Draft
Vector tests #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorbros
force-pushed
the
vector
branch
3 times, most recently
from
0318df2
to
df523b8
Compare
rukai
reviewed
May 2, 2024
conorbros
force-pushed
the
vector
branch
2 times, most recently
from
56fc0a4
to
dc56294
Compare
benbromhead
approved these changes
May 7, 2024
conorbros
force-pushed
the
vector
branch
2 times, most recently
from
4be2754
to
177cf1a
Compare
|
This was marked as "ready to review" but the PR still depends on your personal cdrs-tokio fork. We can be a bit more lenient with dependencies only used for tests, but if shotover itself uses git deps then we will be unable to publish new shotover releases to crates.io |
|
Thanks. I've updated krojew/cdrs-tokio#179 and will progress this PR once it's merged. |
CodSpeed Performance ReportMerging #1570 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.