Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] rename variable differentDeliveryAddress into isDeliveryAddressDifferentFromBilling #3161

Merged
merged 3 commits into from
May 22, 2024
Merged

[shopsys] rename variable differentDeliveryAddress into isDeliveryAddressDifferentFromBilling #3161

merged 3 commits into from
May 22, 2024

Conversation

AndrejBlaho
Copy link
Contributor

@AndrejBlaho AndrejBlaho commented May 13, 2024 •
edited by github-actions bot

Q A
Description, reason for the PR Rename bool variable differentDeliveryAddress into more reasonable isDeliveryAddressDifferentFromBilling
New feature No
BC breaks Yes
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@AndrejBlaho AndrejBlaho self-assigned this May 13, 2024
@AndrejBlaho AndrejBlaho added the DX & Refactoring Requests for DX improvements and refactorings label May 13, 2024
@AndrejBlaho AndrejBlaho force-pushed the ab-rename-delivery-address-variable branch 2 times, most recently from 4dc9e30 to 0d91d16 Compare May 13, 2024 11:33
@AndrejBlaho AndrejBlaho force-pushed the ab-rename-delivery-address-variable branch from 0d91d16 to ee91bbb Compare May 13, 2024 11:38
@AndrejBlaho AndrejBlaho changed the title rename variable differentDeliveryAddress into isDeliveryAddressDifferentFromBilling [shopsys] rename variable differentDeliveryAddress into isDeliveryAddressDifferentFromBilling May 13, 2024
@AndrejBlaho AndrejBlaho reopened this May 13, 2024
@AndrejBlaho AndrejBlaho force-pushed the ab-rename-delivery-address-variable branch from e234369 to 0401c9d Compare May 14, 2024 04:38
vitek-rostislav
vitek-rostislav requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@vitek-rostislav vitek-rostislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have added a few notes, plus please check the failing build 🙏

packages/frontend-api/src/Model/Mutation/Order/CreateOrderMutation.php Show resolved Hide resolved
project-base/storefront/components/Pages/Order/ContactInformation/ContactInformationContent.tsx Show resolved Hide resolved
UPGRADE-15.0.md Outdated Show resolved Hide resolved
@AndrejBlaho
Copy link
Contributor Author

@vitek-rostislav Tweaked upgrade notes according to your comments. Is it enough like this or would you do it some other way?

@AndrejBlaho AndrejBlaho force-pushed the ab-rename-delivery-address-variable branch 2 times, most recently from 5c1cd3b to 789419d Compare May 22, 2024 05:48
@AndrejBlaho AndrejBlaho force-pushed the ab-rename-delivery-address-variable branch from 789419d to 6196da0 Compare May 22, 2024 07:39
@AndrejBlaho AndrejBlaho merged commit 310993a into 15.0 May 22, 2024
17 checks passed
@AndrejBlaho AndrejBlaho deleted the ab-rename-delivery-address-variable branch May 22, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitek-rostislav vitek-rostislav vitek-rostislav approved these changes

Assignees

@AndrejBlaho AndrejBlaho

Labels
DX & Refactoring Requests for DX improvements and refactorings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndrejBlaho @vitek-rostislav