Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] a little spring cleanup #3157

Open
wants to merge 36 commits into
base: 15.0
Choose a base branch
from
Open

[shopsys] a little spring cleanup #3157

wants to merge 36 commits into from

Conversation

vitek-rostislav
Copy link
Contributor

@vitek-rostislav vitek-rostislav commented May 8, 2024 •
edited by github-actions bot

Q A
Description, reason for the PR There are a lot of features implemented in the project-base. Eventually, we want to get rid of the features in project-base, they should be moved to the appropriate packages. When analyzing the whole repository, I came across features/pieces of code, that I was able to move right away without additional effort so I did that, and the result is this PR.
New feature No
BC breaks Yes
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@vitek-rostislav vitek-rostislav changed the title WIP [shopsys] a little spring cleanup [shopsys] a little spring cleanup May 9, 2024
@vitek-rostislav vitek-rostislav force-pushed the rv-cleanup branch 4 times, most recently from 575f7e3 to 7cc79b5 Compare May 10, 2024 06:47
@vitek-rostislav
remove NotNullableColumnsFinder from project-base
072b7a1 
- its parent from the framework package does the same job
@vitek-rostislav
remove QueryBuilderExtender::getJoinsFromQueryBuilder() from project-…
e71a89d 
…base

- the method is duplicated with its parent
@vitek-rostislav
remove IndexRepository from project-base
5d8ac7d 
- the same logic is provided by its parent
@vitek-rostislav
remove EntityExtensionSubscriber from project-base
68a5452 
- the same logic is provided by its parent
- #2473 is already solved
@vitek-rostislav
remove ErrorPagesFacade from the project-base
93b496f 
- the environment distinguishing was moved to its parent
@vitek-rostislav
move FormBuilderHelper from project-base to the framework package
61c162e
@vitek-rostislav
move ArrayWithPaginationDataSource from project-base to the framework…
715f5cc 
… package
@vitek-rostislav
move TransactionalMasterRequestListener extension into the frontend-a…
ef00e73 
…pi package
@vitek-rostislav
move LocaleHelper from project-base to the framework package
6046c49 
- add most common locales to the constants
@vitek-rostislav
remove RedisFacade from the project-base
198a1fc 
- the closeAllClients() method was unused
@vitek-rostislav
remove unused methods from UploadedFile* classes in project-base
33dfda5
@vitek-rostislav
move UploadedFileController from project-base to the framework package
4f487e4
@vitek-rostislav
move rest of the advert-related logic from project-base to the framew…
5de3da8 
…ork package
@vitek-rostislav
remove ArticleController extension from project-base
4a658ec 
- the logic was moved to the parent class
@vitek-rostislav
move DomainController::localeTabsAction() from project-base to the fr…
c30f986 
…amework package
@vitek-rostislav
move RedisController from project-base to the framework package
bcb59b0
@vitek-rostislav
remove ArticleBreadcrumbGenerator extension from project-base
c66459c 
- the parent class now implements DomainBreadcrumbGeneratorInterface
@vitek-rostislav
remove CountryRepository::createSortedJoinedQueryBuilder() extension …
32860fc 
…from project-base

- the logic is now implemented in the parent class
@vitek-rostislav
remove FeedFacade::createFeedExport() extension in project-base
69d227e 
- the method was identical to the parent one
@vitek-rostislav
remove OrderStatusGridFactory::create() extension from project-base
fe05041 
- the logic is the same in the parent class
@vitek-rostislav
remove OrderStatus::setType() extension from project-base
a530d47 
- the logic is the same in the parent class
@vitek-rostislav
remove unused OrderCreatedResult class
ad95993
@vitek-rostislav
remove PaymentGridFactory::create() extension from project-base
0aa6c6d 
- the logic is moved to the framework package
@vitek-rostislav
remove IndependentPaymentVisibilityCalculation::isIndependentlyVisibl…
3b5fe3b 
…e() extension from project-base

- the logic is moved to the framework package
@vitek-rostislav
cleanup PaymentDataFactory in project-base
d5fdd69 
- all the logic moved to the framework package
@vitek-rostislav
move PaymentFacade/Repository logic from project-base to the framewor…
5b17d7d 
…k package
@vitek-rostislav
move CachedBestsellingProductFacade::getAllOfferedBestsellingProductI…
3bf7fdf 
…ds() from project-base to the framework package

- removed deprecated getAllOfferedBestsellingProducts()
@vitek-rostislav
move ProductFilterCountDataElasticsearchRepository::mergeParameterCou…
a19d90b 
…ntData() from project-base to the framework package
@vitek-rostislav
remove TransportGridFactory::create() extension from project-base
f7f8d28 
- the logic is moved to the framework package
@vitek-rostislav
move CsrfExtension from project-base to the framework package
4206fd2
@vitek-rostislav
remove extension of LocalizationExtension in project-base
11e6bcd 
- the logic is moved to the parent class
@vitek-rostislav
remove extension of PriceExtension in project-base
50f4c98 
- the logic is moved to the parent class
@vitek-rostislav
dump translations
49cae9b
@vitek-rostislav
add upgrade notes
9c689be
@vitek-rostislav
TransactionalMasterRequestListener: move the extended logic directly …
b4f469e 
…to the framework package
@vitek-rostislav
TransactionalMasterRequestListener: refectored for better extansibility
d42efa2 
- created TransactionalMasterRequestConditionProviderInterface that is used to determinate whether a transaction should be initialized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossmannmartin grossmannmartin grossmannmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vitek-rostislav @grossmannmartin