Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] include domain sale exclusion in product querying more appropriately #3141

Merged
merged 3 commits into from
May 22, 2024
Merged

[shopsys] include domain sale exclusion in product querying more appropriately #3141

merged 3 commits into from
May 22, 2024

Conversation

AndrejBlaho
Copy link
Contributor

@AndrejBlaho AndrejBlaho commented Apr 29, 2024 •
edited by github-actions bot

Q A
Description, reason for the PR There was discrepancy in project base between querying of sellable and listable products where domain sale exclusion was included in sellable products only. Domain sale exclusion is now moved to more generalized offered products which should be more appropriate. Issue stemmed from domain sale excluded products being included in sellable products sitemap which is not desired behavior.
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

馃寪 Live Preview:

@AndrejBlaho AndrejBlaho added the Enhancement New feature or request for change from user point of view label Apr 29, 2024
@AndrejBlaho AndrejBlaho self-assigned this Apr 29, 2024
@AndrejBlaho AndrejBlaho force-pushed the ab-sellable-products-in-sitemap branch 4 times, most recently from 7e6b52c to cb59253 Compare April 30, 2024 09:42
@AndrejBlaho AndrejBlaho force-pushed the ab-sellable-products-in-sitemap branch 3 times, most recently from 5608a01 to 89e00a0 Compare May 3, 2024 08:35
@AndrejBlaho AndrejBlaho force-pushed the ab-sellable-products-in-sitemap branch 2 times, most recently from 02c50b1 to 6730dfa Compare May 9, 2024 09:03
@AndrejBlaho AndrejBlaho force-pushed the ab-sellable-products-in-sitemap branch 2 times, most recently from bc68d90 to a5a6e6e Compare May 16, 2024 11:28
@AndrejBlaho AndrejBlaho force-pushed the ab-sellable-products-in-sitemap branch from a5a6e6e to 76b9f98 Compare May 22, 2024 08:22
@AndrejBlaho AndrejBlaho merged commit d5ce8ba into 15.0 May 22, 2024
17 checks passed
@AndrejBlaho AndrejBlaho deleted the ab-sellable-products-in-sitemap branch May 22, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitek-rostislav vitek-rostislav vitek-rostislav approved these changes

Assignees

@AndrejBlaho AndrejBlaho

Labels
Enhancement New feature or request for change from user point of view
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndrejBlaho @vitek-rostislav