-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
redesign product page + some base elements #3132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvikito
force-pushed
the
tv-ssp-2250-redesign-product-page
branch
4 times, most recently
from
April 25, 2024 23:10
01842e5
to
f655d23
Compare
VaniaToper
reviewed
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 馃憤
project-base/storefront/components/Pages/ProductDetail/ProductDetailAvailability.tsx
Outdated
Show resolved
Hide resolved
project-base/storefront/components/Pages/ProductDetail/ProductDetailAvailability.tsx
Outdated
Show resolved
Hide resolved
project-base/storefront/components/Pages/ProductDetail/ProductDetailAvailability.tsx
Outdated
Show resolved
Hide resolved
project-base/storefront/components/Pages/ProductDetail/ProductDetailAvailabilityList.tsx
Outdated
Show resolved
Hide resolved
tvikito
force-pushed
the
tv-ssp-2250-redesign-product-page
branch
7 times, most recently
from
May 3, 2024 09:43
988dab7
to
e7a56e9
Compare
VaniaToper
force-pushed
the
tv-ssp-2250-redesign-product-page
branch
2 times, most recently
from
May 13, 2024 12:58
dec49ac
to
87de105
Compare
sebaholesz
requested changes
May 14, 2024
project-base/storefront/components/Pages/ProductDetail/ProductDetailContent.tsx
Outdated
Show resolved
Hide resolved
VaniaToper
force-pushed
the
tv-ssp-2250-redesign-product-page
branch
2 times, most recently
from
May 16, 2024 00:44
04728c7
to
8ad9b77
Compare
- on Chrome there was issue when clicking on next/previous button while slider is only partially visible - in this case scroll freeze after scroll into slider element and is stucked
VaniaToper
force-pushed
the
tv-ssp-2250-redesign-product-page
branch
2 times, most recently
from
May 20, 2024 07:03
75bdf9b
to
8bbef96
Compare
VaniaToper
force-pushed
the
tv-ssp-2250-redesign-product-page
branch
from
May 20, 2024 08:50
8bbef96
to
96284bd
Compare
sebaholesz
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃寪 Live Preview: