Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] Restyle orders #3123

Open
wants to merge 5 commits into
base: 15.0
Choose a base branch
from
Open

[shopsys] Restyle orders #3123

wants to merge 5 commits into from

Conversation

VaniaToper
Copy link
Contributor

@VaniaToper VaniaToper commented Apr 23, 2024 •
edited by github-actions bot

Q A
Description, reason for the PR ...
New feature Yes/No
BC breaks Yes/No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes/No

🌐 Live Preview:

@VaniaToper VaniaToper changed the title Ih ssp 2266 restyle orders [shopsys] Restyle orders Apr 23, 2024
@VaniaToper VaniaToper force-pushed the ih-ssp-2266-restyle-orders branch 3 times, most recently from becf97c to 5e56b03 Compare April 25, 2024 11:01
sebaholesz
sebaholesz requested changes May 3, 2024
View reviewed changes
project-base/storefront/utils/animations/framerMotionPlugins.ts Show resolved Hide resolved
project-base/storefront/pages/_app.tsx Show resolved Hide resolved
project-base/storefront/graphql/requests/orders/queries/OrdersCountQuery.graphql Show resolved Hide resolved
project-base/storefront/utils/user/useUserMenuItems.ts Outdated Show resolved Hide resolved
project-base/storefront/utils/user/useUserMenuItems.ts Outdated Show resolved Hide resolved
project-base/storefront/components/Blocks/UserNavigation/UserNavigation.tsx Outdated Show resolved Hide resolved
project-base/storefront/components/Forms/Button/LinkButton.tsx Outdated Show resolved Hide resolved
project-base/storefront/components/Layout/CustomerLayout.tsx Outdated Show resolved Hide resolved
project-base/storefront/components/Layout/CustomerLayout.tsx Outdated Show resolved Hide resolved
sebaholesz
sebaholesz requested changes May 3, 2024
View reviewed changes
Copy link
Contributor

@sebaholesz sebaholesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your pipelines are failing. Please, fix them before another round of CR.

sebaholesz
sebaholesz requested changes May 11, 2024
View reviewed changes
project-base/storefront/public/locales/cs/common.json Outdated Show resolved Hide resolved
project-base/storefront/public/locales/cs/common.json Outdated Show resolved Hide resolved
project-base/storefront/public/locales/cs/common.json Outdated Show resolved Hide resolved
project-base/storefront/public/locales/cs/common.json Outdated Show resolved Hide resolved
project-base/storefront/public/locales/en/common.json Outdated Show resolved Hide resolved
...apshots/e2e/order/contactInformation.cy.ts/keep-changed-contact-information-after-reload.png Outdated Show resolved Hide resolved
...apshots/e2e/order/contactInformation.cy.ts/keep-changed-contact-information-after-reload.png Outdated Show resolved Hide resolved
...order/contactInformation.cy.ts/no-transport-and-payment-in-contact-information-logged-in.png Outdated Show resolved Hide resolved
...efront/cypress/snapshots/e2e/transportAndPayment/transportSelect.cy.ts/transport-to-home.png Outdated Show resolved Hide resolved
...efront/cypress/snapshots/e2e/transportAndPayment/transportSelect.cy.ts/transport-to-home.png Outdated Show resolved Hide resolved
@sebaholesz
Copy link
Contributor

sebaholesz commented May 11, 2024 •
edited

After rebase, these things are mostly ok. Let's deal with the rest elsewhere.

@pk16011990 please take a look at the new UI. In my opinion it looks really bad. I understand that this PR is not about that, but then it should not implement the UI changes.

In my opinion, @VaniaToper should either completely remove the color/UI changes and just redesign the orders page, or implement them fully without breaking the rest of the app. I would just say that now the shop looks horrible and looks nothing like the previous design, or the new design, for that matter.

With these changes, we will work on a visually broken app for weeks, maybe months, which is really not nice.

@VaniaToper VaniaToper force-pushed the ih-ssp-2266-restyle-orders branch 3 times, most recently from 6323536 to 279f0ba Compare May 11, 2024 09:34
@VaniaToper VaniaToper changed the base branch from 15.0 to tv-ssp-2250-redesign-product-page May 11, 2024 09:34
@VaniaToper VaniaToper force-pushed the tv-ssp-2250-redesign-product-page branch from dec49ac to 87de105 Compare May 13, 2024 12:58
sebaholesz
sebaholesz approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@sebaholesz sebaholesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the failing pipeline (which is due to unformatted markdown), this PR is okay.

@VaniaToper VaniaToper force-pushed the tv-ssp-2250-redesign-product-page branch 3 times, most recently from 75bdf9b to 8bbef96 Compare May 20, 2024 07:03
@VaniaToper VaniaToper force-pushed the tv-ssp-2250-redesign-product-page branch from 8bbef96 to 96284bd Compare May 20, 2024 08:50
Base automatically changed from tv-ssp-2250-redesign-product-page to 15.0 May 20, 2024 10:09
@VaniaToper VaniaToper force-pushed the ih-ssp-2266-restyle-orders branch 2 times, most recently from 3cdae6a to d6f03c0 Compare May 22, 2024 12:56
Ivan Hodynchuk added 4 commits May 25, 2024 23:02
Create customer layout
6581908
Restyle orders page
0ae1948
Implement user menu
7b3778e
Implement link button
1b99303 
A link that looks like a button but has an anchor tag inside
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebaholesz sebaholesz sebaholesz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VaniaToper @sebaholesz