Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] refactored order creation #3084

Open
wants to merge 51 commits into
base: 15.0
Choose a base branch
from
Open

[shopsys] refactored order creation #3084

wants to merge 51 commits into from

Conversation

grossmannmartin
Copy link
Member

@grossmannmartin grossmannmartin commented Mar 28, 2024 •
edited by github-actions bot

Q A
Description, reason for the PR This PR completely changes how the order is created. Previously used OrderPreviewCalculation was replaced with more versatile middlewares. See documentation for more info
New feature Yes
BC breaks Yes
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@grossmannmartin grossmannmartin force-pushed the mg-order-processor branch 8 times, most recently from a4b33d1 to 5d5662c Compare April 8, 2024 12:39
@grossmannmartin grossmannmartin force-pushed the mg-order-processor branch 4 times, most recently from 9cad0a6 to 2037787 Compare April 13, 2024 20:39
@grossmannmartin grossmannmartin changed the base branch from 15.0 to rv-order-movements April 13, 2024 20:40
@grossmannmartin grossmannmartin force-pushed the mg-order-processor branch 5 times, most recently from 528db7d to 6e52ed1 Compare April 17, 2024 15:14
vitek-rostislav
vitek-rostislav requested changes Apr 18, 2024
View reviewed changes
packages/framework/src/Model/Order/Item/OrderItem.php Outdated Show resolved Hide resolved
packages/framework/src/Model/Order/Item/OrderItemData.php Show resolved Hide resolved
project-base/app/tests/FrontendApiBundle/Functional/Order/OrderTestTrait.php Show resolved Hide resolved
packages/framework/src/Model/Order/PromoCode/ProductPromoCodeFiller.php Show resolved Hide resolved
packages/framework/src/Model/Order/Item/OrderItem.php Outdated Show resolved Hide resolved
...mework/src/Model/Order/Processing/OrderProcessorMiddleware/PersonalPickupPointMiddleware.php Show resolved Hide resolved
...mework/src/Model/Order/Processing/OrderProcessorMiddleware/PersonalPickupPointMiddleware.php Show resolved Hide resolved
packages/framework/src/Model/Order/PromoCode/CurrentPromoCodeFacade.php Outdated Show resolved Hide resolved
packages/framework/src/Model/Order/PromoCode/CurrentPromoCodeFacade.php Show resolved Hide resolved
packages/framework/src/Model/Order/PromoCode/CurrentPromoCodeFacade.php Show resolved Hide resolved
@grossmannmartin grossmannmartin force-pushed the mg-order-processor branch 2 times, most recently from 8c2f555 to 376f117 Compare April 22, 2024 14:05
@vitek-rostislav vitek-rostislav force-pushed the rv-order-movements branch 2 times, most recently from b8c71af to 29e136c Compare April 24, 2024 07:36
Base automatically changed from rv-order-movements to 15.0 April 24, 2024 07:51
@grossmannmartin grossmannmartin force-pushed the mg-order-processor branch 4 times, most recently from bc77619 to 543fec7 Compare April 25, 2024 20:42
@grossmannmartin
removed unused OrderData::$password property
1f8022d
@grossmannmartin
domainConfig and customerUser is now a part of OrderInput
255885d
@grossmannmartin
CustomerUser is now taken from OrderInput for order creation
0d44a47
@grossmannmartin
renamed CreateOrderFacade to PlaceOrderFacade
415df2f
@grossmannmartin
refactored newsletter subscriber
9a2937c
@grossmannmartin
refactored CurrentCustomerUserTest
531b765
@grossmannmartin
place order now do all necessary tasks
30dc3e9 
- send email, dispatch message, edit customer delivery address. subscribe to newsletter, ...
@grossmannmartin
reimplemented set delivery address data by uuid with middleware
4f279d2 
- reimplemented #3105 into the middleware
@grossmannmartin
added shortcut to get cart transport/payment price
b603016
@grossmannmartin
applied promo code is now taken into account in priceByTransportQuery…
eee2bed 
… and priceByPaymentQuery
@grossmannmartin
discounts are now stored natively in negative amount
7fabb41
@grossmannmartin
unified order item creation
a45aeb9 
- order item type now uses enum class
@grossmannmartin
zero prices are set in factory for better extensibility
dc867dc
@grossmannmartin
improved code quality in middlewares
64c3ab6
@grossmannmartin
Store name is now added to the transport name with personal pickup
b54c6d2
@grossmannmartin
added nominal discount middleware
c8cc98b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasLudvik TomasLudvik TomasLudvik requested changes

@vitek-rostislav vitek-rostislav vitek-rostislav approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
DX & Refactoring Requests for DX improvements and refactorings Enhancement New feature or request for change from user point of view
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grossmannmartin @TomasLudvik @vitek-rostislav