Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CategoryTreeSorting.init jquery UI performance #3013

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

malyMiso
Copy link
Contributor

@malyMiso malyMiso commented Feb 4, 2024

Q A
Description, reason for the PR There is a perfromace leak when working with category sorting tree. See jquery/jquery-ui#2062. Upgrading Jquery UI to newer version does not work (it would be nice to upgrade all JS dependecies for admin 😉. It is not part of this PR). On my project with 1K categories CategoryTreeSorting.init took 741ms, with CPU throttling (6x slowdown Chrome) it took 5096 ms. After change it was 257ms with CPU throtlling on and 41ms without throttling. There are some points against this solution, discussed in jquery/jquery-ui#2063, so please have a look before accepting PR.
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@malyMiso malyMiso changed the title Mt jquery UI performance CategoryTreeSorting.init jquery UI performance Feb 4, 2024
@grossmannmartin grossmannmartin merged commit 5769e19 into 14.0 Feb 14, 2024
17 checks passed
@grossmannmartin grossmannmartin deleted the mt-jquery-ui-performance branch February 14, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants