Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ToDo] PhpStan level 6 + Rector for assistance #2925

Draft
wants to merge 13 commits into
base: 14.0
Choose a base branch
from
Draft

Conversation

pk16011990
Copy link
Member

Q A
Description, reason for the PR I want a higher PhpStan level, and I do not want to update all files manually
New feature Yes/No (probably yes)
BC breaks Yes
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

It needs a repeated execution of Rector because each run adds more context for other rules. Except for the \Shopsys\FrameworkBundle\Component\Rector\GuessReturnTypeByImplementationRector because It is broken for repeated executions

Todo:

  • Coding standards
  • Applying not only to shopsys/framework and project-base
  • Codestyle in Rector rules
  • Decide how to add Rector to a project and where (coding-standards?)
  • fix remaining PhpStan errors (299)
  • fix everything that has been broken (build has to be successful)
  • upgrade notes

@pk16011990 pk16011990 marked this pull request as draft November 19, 2023 16:00
@pk16011990 pk16011990 added Help wanted We need your help or opinion how to resolve this DX & Refactoring Requests for DX improvements and refactorings labels Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX & Refactoring Requests for DX improvements and refactorings Help wanted We need your help or opinion how to resolve this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant