Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] added ability to schedule each feed for specific time same way as crons #2922

Merged
merged 7 commits into from Nov 28, 2023
Merged

[shopsys] added ability to schedule each feed for specific time same way as crons #2922

merged 7 commits into from Nov 28, 2023

Conversation

TomasLudvik
Copy link
Member

@TomasLudvik TomasLudvik commented Nov 15, 2023 •
edited by github-actions bot

Q A
Description, the reason for the PR Some feeds might need to be generated at a specific time or in a different schedule than daily/hourly.
New feature Yes
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@TomasLudvik TomasLudvik added the Enhancement New feature or request for change from user point of view label Nov 15, 2023
vitek-rostislav
vitek-rostislav requested changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@vitek-rostislav vitek-rostislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, nice job there, I have added a few notes 😉

packages/framework/src/Model/Feed/FeedModuleFactory.php Outdated Show resolved Hide resolved
packages/framework/src/Model/Feed/FeedModuleFactoryInterface.php Show resolved Hide resolved
packages/framework/tests/Unit/Model/Feed/FeedCronModuleTest.php Show resolved Hide resolved
packages/framework/tests/Unit/Model/Feed/FeedCronModuleTest.php Outdated Show resolved Hide resolved
docs/model/product-feeds.md Show resolved Hide resolved
docs/model/product-feeds.md Show resolved Hide resolved
packages/framework/src/Command/ScheduleFeedsCommand.php Outdated Show resolved Hide resolved
packages/framework/src/Command/ScheduleFeedsCommand.php Outdated Show resolved Hide resolved
packages/framework/src/Component/DateTimeHelper/DateTimeHelper.php Outdated Show resolved Hide resolved
UPGRADE-14.0.md Show resolved Hide resolved
vitek-rostislav
vitek-rostislav requested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@vitek-rostislav vitek-rostislav left a comment •
edited by TomasLudvik

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback from tests:

  • admin/feed/list/ now fails on error - (FeedNotFoundException) (smoke test is failing on that too)
  • failing smoke test for admin_feed_schedule route

Otherwise, it works as expected 👌 ✔️

@TomasLudvik
fixed validating of time set to crons
4531c1a 
- crons can be run every minute so validation has to reflect that
@TomasLudvik TomasLudvik merged commit df87fcd into 14.0 Nov 28, 2023
18 checks passed
@TomasLudvik TomasLudvik deleted the tl-run-crons-separately branch November 28, 2023 10:20
@vitek-rostislav vitek-rostislav changed the title [shopsys] added ability to schedule each cron for specific time same way as crons [shopsys] added ability to schedule each feed for specific time same way as crons Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pk16011990 pk16011990 pk16011990 approved these changes

@vitek-rostislav vitek-rostislav vitek-rostislav approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request for change from user point of view
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TomasLudvik @pk16011990 @vitek-rostislav