Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] update symfony to version 4.4 #1704

Merged
merged 69 commits into from
Mar 18, 2020
Merged

[shopsys] update symfony to version 4.4 #1704

merged 69 commits into from
Mar 18, 2020

Conversation

pesektomas
Copy link
Contributor

@pesektomas pesektomas commented Feb 26, 2020 •
edited

Q A
Description, reason for the PR This PR updates dependencies for last LTS version of symfony (version ^4.4.0)
New feature No
BC breaks Yes
Fixes issues closes #1388, closes #907
Have you read and signed our License Agreement for contributions? Yes

@pesektomas pesektomas force-pushed the tp-symfony4 branch 4 times, most recently from 0020fff to 6a45917 Compare February 28, 2020 08:42
@pesektomas pesektomas mentioned this pull request Feb 28, 2020
Closed
grossmannmartin
grossmannmartin requested changes Mar 1, 2020
View reviewed changes
Copy link
Member

@grossmannmartin grossmannmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work here, I can imagine it was not an easy task.

Can you please check my comments?

yaml-standards.yaml Outdated Show resolved Hide resolved
yaml-standards.yaml Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
packages/framework/tests/Unit/Component/HttpFoundation/FragmentHandlerTest.php Show resolved Hide resolved
project-base/config/packages/framework_extra.yml Show resolved Hide resolved
project-base/config/services.yaml Outdated Show resolved Hide resolved
project-base/config/services_test.yml Outdated Show resolved Hide resolved
project-base/src/Controller/Front/RobotsController.php Show resolved Hide resolved
@grossmannmartin grossmannmartin mentioned this pull request Mar 2, 2020
Closed
4 tasks
@pesektomas pesektomas force-pushed the tp-symfony4 branch 3 times, most recently from 9fdeb09 to 2abbb2d Compare March 3, 2020 08:09
grossmannmartin
grossmannmartin previously requested changes Mar 3, 2020
View reviewed changes
Copy link
Member

@grossmannmartin grossmannmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) thanks for the fixes. Just a few more thoughts. I believe you can update files in project-base.

packages/framework/src/Component/FlashMessage/FlashMessageTrait.php Outdated Show resolved Hide resolved
packages/framework/src/Component/FlashMessage/FlashMessageTrait.php Outdated Show resolved Hide resolved
packages/framework/src/Model/AdvancedSearchOrder/Filter/OrderLastNameFilter.php Outdated Show resolved Hide resolved
packages/framework/src/Model/Cart/Item/CartItem.php Outdated Show resolved Hide resolved
packages/framework/tests/Unit/Component/Cron/CronFacadeTest.php Show resolved Hide resolved
@pesektomas pesektomas mentioned this pull request Mar 4, 2020
Closed
TomasLudvik
TomasLudvik requested changes Mar 5, 2020
View reviewed changes
composer.json Show resolved Hide resolved
packages/framework/src/Controller/Admin/FlashMessageController.php Outdated Show resolved Hide resolved
packages/framework/src/Model/Security/Roles.php Show resolved Hide resolved
packages/framework/src/Command/ChangeAdminPasswordCommand.php Outdated Show resolved Hide resolved
packages/framework/src/Component/Money/Money.php Outdated Show resolved Hide resolved
packages/framework/src/Form/Transformers/NumericToMoneyTransformer.php Outdated Show resolved Hide resolved
packages/framework/tests/Unit/Model/Pricing/RoundingTest.php Show resolved Hide resolved
packages/framework/src/Component/FlashMessage/FlashMessageTrait.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@pesektomas pesektomas force-pushed the tp-symfony4 branch 4 times, most recently from 121a352 to 239c869 Compare March 10, 2020 06:41
@pesektomas pesektomas force-pushed the tp-symfony4 branch 2 times, most recently from c04d60f to 8a7862c Compare March 10, 2020 12:48
@pesektomas pesektomas force-pushed the tp-symfony4 branch 3 times, most recently from f3c7f69 to 2332990 Compare March 11, 2020 09:03
TomasLudvik
TomasLudvik requested changes Mar 16, 2020
View reviewed changes
upgrade/UPGRADE-v9.0.0-dev.md Outdated Show resolved Hide resolved
upgrade/UPGRADE-v9.0.0-dev.md Outdated Show resolved Hide resolved
upgrade/UPGRADE-v9.0.0-dev.md Outdated Show resolved Hide resolved
upgrade/UPGRADE-v9.0.0-dev.md Outdated Show resolved Hide resolved
upgrade/UPGRADE-v9.0.0-dev.md Outdated Show resolved Hide resolved
upgrade/UPGRADE-v9.0.0-dev.md Outdated Show resolved Hide resolved
upgrade/UPGRADE-v9.0.0-dev.md Outdated Show resolved Hide resolved
upgrade/UPGRADE-v9.0.0-dev.md Show resolved Hide resolved
upgrade/UPGRADE-v9.0.0-dev.md Outdated Show resolved Hide resolved
upgrade/UPGRADE-v9.0.0-dev.md Outdated Show resolved Hide resolved
@grossmannmartin grossmannmartin dismissed their stale review March 17, 2020 07:44

final review was done by someone else

pesektomas and others added 14 commits March 17, 2020 11:10
@pesektomas
started use entity manager from parent class in functional test
5c95160
@pesektomas
used static::bootKernel() for access to container in smoke feed test
421f74e
@pesektomas
refactored ProductAvailabilityCalculationTest
83f8b39
@pesektomas
used persistentReferenceFacade from parent class in OrderFacadeTest
aae5f5c
@pesektomas
started use entities from framework in EntityExtensionTest
625ae3e 
Entity extensibility is expected to be only two levels - framework entity and then project-base entity. Multi level extensibility may cause problems and is not supported
@pesektomas
refactored ProductRenameRedirectPreviousUrlTest
3accbf5
@pesektomas
moved web-server-bundle to require-dev
befc2e3
@pesektomas
updated twig
c5e6d03
@pesektomas
updated dependencies in packages/*
cb45d09
@TomasLudvik @pesektomas
build-demo-dev and build-dev now run phing checks instead of checks-diff
cd09265 
- MacOS and Windows Docker installations with docker-sync do not have git repository synced inside the container so this would lead to error
@TomasLudvik @pesektomas
phing target tests now depends on npm-install-dependencies and error-…
f9f484d 
…pages-generate

- without running error-pages-generate might smoke tests fail on multiple errors with no existent 404 and 500 error pages
- without running npm-install-dependencies could tests-unit fail on non existing dependencies
@TomasLudvik @pesektomas
updated installation documentation using docker on mac and windows wi…
f01fb75 
…th new requirements for memory
@TomasLudvik @pesektomas
removed _bootstrap.php files because they are not in use and cause de…
a3c67e7 
…precations
@pesektomas
added upgrade notes for symfony4
4e7c597
@pesektomas
removed void type declaration in LocalizationHelper
4c63650 
fixed codeception build which does not generate the action file correctly (method void return some value)
@pesektomas
removed domainRouterFactory from FunctionalTestCase
57fcbf2
@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.7% 2.7% Duplication

@pesektomas pesektomas merged commit d3515cb into master Mar 18, 2020
@pesektomas pesektomas mentioned this pull request Mar 20, 2020
Merged
@grossmannmartin grossmannmartin mentioned this pull request Apr 3, 2020
Merged
@pesektomas pesektomas mentioned this pull request Apr 7, 2020
Closed
vitek-rostislav added a commit that referenced this pull request Apr 13, 2020
@vitek-rostislav
fix ErrorExtractor::getAllErrorsAsArray()
e497dd5 
- according to the usage of the method, the second parameter should be an array
- the bug was introduced in #1704
(3761f8e)
@vitek-rostislav vitek-rostislav mentioned this pull request Apr 13, 2020
Merged
grossmannmartin pushed a commit that referenced this pull request Apr 14, 2020
@vitek-rostislav @grossmannmartin
fix ErrorExtractor::getAllErrorsAsArray()
6d07dd6 
- according to the usage of the method, the second parameter should be an array
- the bug was introduced in #1704
(3761f8e)
@pk16011990 pk16011990 mentioned this pull request Apr 20, 2020
Closed
@pesektomas pesektomas deleted the tp-symfony4 branch April 24, 2020 06:39
@vitek-rostislav vitek-rostislav mentioned this pull request Apr 27, 2020
Open
grossmannmartin pushed a commit that referenced this pull request May 13, 2020
@vitek-rostislav @grossmannmartin
fix ErrorExtractor::getAllErrorsAsArray()
e72cdce 
- according to the usage of the method, the second parameter should be an array
- the bug was introduced in #1704
(3761f8e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasLudvik TomasLudvik TomasLudvik approved these changes

@sslt sslt sslt approved these changes

@grossmannmartin grossmannmartin grossmannmartin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Services needed in integration tests should not be manually registered as public
4 participants
@pesektomas @grossmannmartin @TomasLudvik @sslt