Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Performance Improvement #252

Merged
merged 2 commits into from Oct 20, 2021
Merged

Minor Performance Improvement #252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2a95d4
minor performance improvment
lmittmann Oct 18, 2021
a271a29
remaining `big.NewInt(0).Set(...)` -> `new(big.Int).Set(...)`
lmittmann Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions decimal.go
View file
Open in desktop
Expand Up @@ -120,7 +120,7 @@ func NewFromInt32(value int32) Decimal {
// NewFromBigInt returns a new Decimal from a big.Int, value * 10 ^ exp
func NewFromBigInt(value *big.Int, exp int32) Decimal {
return Decimal{
value: big.NewInt(0).Set(value),
value: new(big.Int).Set(value),
exp: exp,
}
}
Expand Down Expand Up @@ -831,7 +831,7 @@ func (d Decimal) IsInteger() bool {
// When the exponent is negative we have to check every number after the decimal place
// If all of them are zeroes, we are sure that given decimal can be represented as an integer
var r big.Int
q := big.NewInt(0).Set(d.value)
q := new(big.Int).Set(d.value)
for z := abs(d.exp); z > 0; z-- {
q.QuoRem(q, tenInt, &r)
if r.Cmp(zeroInt) != 0 {
Expand Down Expand Up @@ -949,7 +949,7 @@ func (d Decimal) Exponent() int32 {
func (d Decimal) Coefficient() *big.Int {
d.ensureInitialized()
// we copy the coefficient so that mutating the result does not mutate the Decimal.
return big.NewInt(0).Set(d.value)
return new(big.Int).Set(d.value)
}

// CoefficientInt64 returns the coefficient of the decimal as int64. It is scaled by 10^Exponent()
Expand Down