add NewNullDecimal #234
Merged
add NewNullDecimal #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like a good idea. Thanks for your contribution @rubensayshi! |
rubensayshi
force-pushed
the
new-null-decimal
branch
from
9d34c3a
to
38c8188
Compare
|
awesome, I fixed the 2 |
|
Looks great tho. Thanks for the contribution once again @rubensayshi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
NullDecimal{d, true}is discouraged (and static analysis tools likego vetwill alert about it) addingNewNullDecimalseems like a nice way make code a bit more readable