properly handle nil value in Scan #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanre-ade
changed the title
njason
requested changes
Oct 9, 2019
serprex
reviewed
Apr 5, 2024
| @@ -970,6 +970,11 @@ func (d Decimal) MarshalBinary() (data []byte, err error) { | |||
|
|
|||
| // Scan implements the sql.Scanner interface for database deserialization. | |||
| func (d *Decimal) Scan(value interface{}) error { | |||
| if value == nil { | |||
| d = nil | |||
There was a problem hiding this comment.
Suggested change
| d = nil | |
| *d = nil |
There was a problem hiding this comment.
Except this won't work because *d expects a Decimal
In recent versions of go you can use sql.Null[decimal.Decimal]
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation breaks expected behaviour of sql scanner when scanning into a pointer. Scanning a
NULLcolumn into a pointerd *Decimalreturns an error instead of the pointer being set to nil