Use common error when removing an unwatched file #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The errors returned by the various implementations of the watcher are all different which makes handling them difficult. This PR follows the suggestion in: fsnotify/fsnotify#455 (comment) by @mattn to create a common error which is wrapped by the implementations. Replaces: fsnotify/fsnotify#455 Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
The errors returned by the various implementations of the watcher are all different
which makes handling them difficult. This PR follows the suggestion in:
fsnotify/fsnotify#455 (comment) by @mattn
to create a common error which is wrapped by the implementations.
Replaces: fsnotify/fsnotify#455
Where should the reviewer start?
fsnotify.go err definition
How should this be manually tested?
Remove an unwatched file and check the error returned.