inotify: don't ignore events for files that don't exist #36
Conversation
port of fsnotify/fsnotify#470 This is quite an odd check, leading to an inconsistent event stream, which also doesn't match what other platforms do. If you do a "CREATE + MODIFY + REMOVE" in quick succession then you probably *want* all three events. If you don't want to operate on non-existing files, then you can check this in your application code. You need to do that already, since this check is far from reliable. In the time between this check and the application code doing something with an event the file may have been deleted already. I looked a bit at the history of this, and looks like it was added in 2013 with cc2c34e; issue 36 refers to this issue on the old repo, which mentions it fixes a memory leak: howeyc/fsnotify#36 I can't reproduce that at all; using the CLI from #463 modified to print the memory and running: for i in $(seq 0 10000); { touch $i; rm $i } Memory stays at about 100/110K in both the current main branch and this. So I think it should be safe to remove.
|
Warning Rate Limit Exceeded@shogo82148 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 26 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
port of fsnotify/fsnotify#470
This is quite an odd check, leading to an inconsistent event stream, which also doesn't match what other platforms do. If you do a "CREATE + MODIFY + REMOVE" in quick succession then you probably want all three events. If you don't want to operate on non-existing files, then you can check this in your application code.
You need to do that already, since this check is far from reliable. In the time between this check and the application code doing something with an event the file may have been deleted already.
I looked a bit at the history of this, and looks like it was added in 2013 with cc2c34e; issue 36 refers to this issue on the old repo, which mentions it fixes a memory leak: howeyc/fsnotify#36
I can't reproduce that at all; using the CLI from #463 modified to print the memory and running:
Memory stays at about 100/110K in both the current main branch and this.
So I think it should be safe to remove.
NOTE: Please do not open a pull request that adds or changes the public API without giving consideration to all supported operating systems.