Skip to content

Commit

Permalink
windows: increase buffer size from 4K to 64K (#485)
Browse files Browse the repository at this point in the history
People are running in to trouble because the 4K buffer can overflow;
see: #72.

This is not a "real" fix, but I think a 64K buffer is acceptable even on
memory-limited machines; no one is running the Windows on an Arduino,
and even with something like 128M of memory, the extra 124K is basically
negligible. There is also no real performance difference between
allocating a large array vs. a small array: they're both comparable.

It should probably be enough for most applications. Need to look in the
future to either dynamically grow the size, or allow setting it similar
to what tilt does as mentioned in #72.
  • Loading branch information
arp242 authored and shogo82148 committed Mar 6, 2024
1 parent 069bd5f commit 5f946ba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion windows.go
Expand Up @@ -185,7 +185,7 @@ type watch struct {
mask uint64 // Directory itself is being watched with these notify flags
names map[string]uint64 // Map of names being watched and their notify flags
rename string // Remembers the old name while renaming a file
buf [4096]byte
buf [65536]byte // 64K buffer
}

type indexMap map[uint64]*watch
Expand Down

0 comments on commit 5f946ba

Please sign in to comment.