Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(host, windows): add UBR (Update Build Revision) to kernel version #1374

Merged
merged 1 commit into from Nov 10, 2022

Conversation

shirou
Copy link
Owner

@shirou shirou commented Nov 5, 2022

fixes #1372

This PR adds UBR (Update Build Revision) to current Build Version.

Notice: this PR breaks compatibility

This PR changes the format of the string returned by host.KernelVersion() as follows. I do not believe there are any applications that parses this string and uses numbers, but if there are such applications and they implement a naive parser, this might be a problem.

From

    host_test.go:181: KernelVersion(): 10.0.22000 Build 22000

to

    host_test.go:181: KernelVersion(): 10.0.22000.1098 Build 22000.1098

@d1ss0nanz
Copy link
Contributor

That was fast!

Thank you.

@shirou shirou merged commit 672e251 into master Nov 10, 2022
@shirou shirou deleted the feature/add_ubr_on_host_windows branch November 10, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include UBR (Update Build Revision) into Windows version number
2 participants