[android][host] fix Info() failure due to forbidden /proc/stat and /proc/uptime #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These files are still accessible on older Android versions (in my test, Android 7.1.2), this change needlessly breaks the function there. We could use https://pkg.go.dev/golang.org/x/sys/unix#Sysinfo, maybe as a fallback to a read error. |
tmm1
force-pushed
the
android-uptime
branch
4 times, most recently
from
42f7a7c
to
07e73f9
Compare
with Android O, /proc/{stat,uptime} both return permission denied
Good idea. I have implemented this approach on the PR, and tested working with Android 11 |
|
@Lomanic wdyt? |
|
Friendly ping |
Lomanic
reviewed
Oct 25, 2022
|
Thanks for the review! How is this looking now? |
|
ping @shirou |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these are not accessible on Android