Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[disk][windows] Support LabelWithContext & SerialNumberWithContext #1273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

56KBs
Copy link
Contributor

@56KBs 56KBs commented Mar 11, 2022

Add support for LabelWithContext & SerialNumberWithContext, additionally returning this data back for the IOCountersWithContext function.

Add support for LabelWithContext & SerialNumberWithContext, additionally returning this data back for the IOCountersWithContext function.
@shirou
Copy link
Owner

shirou commented Mar 12, 2022

memo: GetVolumeInformationW

I can confirm this works like a charm on my Windows 11 and passes all tests under disk package.

=== RUN   TestDisk_io_counters
    disk_test.go:63: C: {"readCount":508079,"mergedReadCount":0,"writeCount":457016,"mergedWriteCount":0,"readBytes":28458717184,"writeBytes":10429160960,"readTime":947,"writeTime":174,"iopsInProgress":0,"ioTime":0,"weightedIO":0,"name":"C:","serialNumber":"3223359191","label":"OS"}

However, the github test have been failed. Do you have any idea about why the test failed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants