Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Test_Connections in process_linux.go #1119

Merged
merged 4 commits into from Aug 28, 2021
Merged

Fixes for Test_Connections in process_linux.go #1119

merged 4 commits into from Aug 28, 2021

Commits on Aug 19, 2021

  1. Test_Connections currently fails intermittently on Linux (and maybe 

    other OSs), and fails consistently if run with `go test -times=N`

On inspection, Go closes TCP connections when they go out of scope and
are garbage collected. I've re-written Test_Connections() to explicitly
close connectections once the test has finished. This has the other
benefit of closing gracefully, which means the -times argument should
work.

I've also removed the t.Skip() calls inside goroutines as they are
unsupported.
    @tbarker25
    tbarker25 committed Aug 19, 2021
    Copy the full SHA
    34cdfa2 View commit details
    Browse the repository at this point in the history

  2. Make sure that Test_AllProcesses_cmdLine doesn't ignore failures.

    @tbarker25
    tbarker25 committed Aug 19, 2021
    Copy the full SHA
    5ce887d View commit details
    Browse the repository at this point in the history

  3. Minor cleanups motivated by staticcheck warnings.

    @tbarker25
    tbarker25 committed Aug 19, 2021
    Copy the full SHA
    bc46619 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Wait for server connection to be established before checking 

    connections.
    @tbarker25
    tbarker25 committed Aug 23, 2021
    Copy the full SHA
    9248140 View commit details
    Browse the repository at this point in the history