Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mem][linux] Fix #1002 only try to parse /proc/meminfo numeric values on fields we're interested in #1004

Merged
merged 2 commits into from Nov 30, 2020
Merged

[mem][linux] Fix #1002 only try to parse /proc/meminfo numeric values on fields we're interested in #1004

merged 2 commits into from Nov 30, 2020

Conversation

Lomanic
Copy link
Collaborator

@Lomanic Lomanic commented Nov 29, 2020

Also add mocked VirtualMemory() tests.

Fixes #1002

shirou
shirou approved these changes Nov 30, 2020
View reviewed changes
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore unexpected line is good way. Thank you so much

@shirou shirou merged commit 478eb4c into shirou:master Nov 30, 2020
@Lomanic Lomanic deleted the issue1002 branch November 30, 2020 13:32
@Lomanic Lomanic mentioned this pull request Jan 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirou shirou shirou approved these changes

Assignees
No one assigned
Labels
package:mem v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fillFromMeminfoWithContext cannot parse /proc/meminfo with multi-valued fields
2 participants
@Lomanic @shirou