Fix []int8 to []byte in disk/disk_openbsd.go due to x/sys/unix type change #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per change in x/sys/unix, these Statfs_t fields are now converted to []byte rather than []int8. Callers with updated x/sys/unix versions will now see something like: > Error: ../../../go/pkg/mod/github.com/shirou/gopsutil@v3.21.5+incompatible/disk/disk_openbsd.go:59:53: cannot use stat.F_mntfromname[:] (type []byte) as type []int8 in argument to common.IntToString > Error: ../../../go/pkg/mod/github.com/shirou/gopsutil@v3.21.5+incompatible/disk/disk_openbsd.go:60:51: cannot use stat.F_mntonname[:] (type []byte) as type []int8 in argument to common.IntToString > Error: ../../../go/pkg/mod/github.com/shirou/gopsutil@v3.21.5+incompatible/disk/disk_openbsd.go:61:52: cannot use stat.F_fstypename[:] (type []byte) as type []int8 in argument to common.IntToString > Error: ../../../go/pkg/mod/github.com/shirou/gopsutil@v3.21.5+incompatible/disk/disk_openbsd.go:149:45: cannot use stat.F_fstypename[:] (type []byte) as type []int8 in argument to common.IntToString It is probably prudent to update to the newer struct definitions as a result. See also: https://groups.google.com/g/golang-codereviews/c/bPBR9-4hV6E See also: https://go-review.googlesource.com/c/sys/+/407195/2 See also: golang/sys@bc2c85a Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Updated via: $ go get -u golang.org/x/sys && go mod tidy We now require upstream commit bc2c85a on OpenBSD due to type changes. Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
|
FWIW, I tested this on an OpenBSD 7.1 machine and it passed. |
shirou
approved these changes
Jun 7, 2022
|
Hi, @shirou! Do you happen to have an estimate for when this will land in a release? We're looking to get this updated in Vault to move some other dependencies forward. Thank you! |
|
gopsutil has a monthly based release policy. so we will release end of June. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was noticed in the Hashicorp Vault CI pipelines during cross-compilation to OpenBSD.
See also: #1309 for context around this change in upstream
x/sys/unix.Resolves: #1309
N.B.: I don't have access to a OpenBSD box to test this out natively.See comment below, thanks @schultz-is!