Update containerd/containerd indirect test dep #15816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking draft until shirou/gopsutil#1310 is resolved to fix the build. |
|
Note that CVE-2022-31030 has come out since so we should also bump |
This dependency is pulled in from our testing infra and not in our final Vault version. However, updating this dep pulls in newer versions of other deps (such as protobuf) which are used at runtime. Updated via: $ go get github.com/containerd/containerd@v1.5.13 && go mod tidy Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Since docker/docker has an indirect dep on containerd, I've updated it as well: $ go get github.com/docker/docker@v20.10.16 && go mod tidy Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
force-pushed
the
cipherboy-fix-docker-version
branch
from
8931bb9
to
a18bdea
Compare
|
Per conversation with @ncabatoff, by using |
stevendpclark
approved these changes
Jun 13, 2022
|
Thanks all! Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency is pulled in from our testing infra and not in our final
Vault version. However, updating this dep pulls in newer versions of
other deps (such as
protobuf) which are used at runtime. Updated via:Since docker/docker has an indirect dep on containerd, I've updated it
as well:
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>Inclined not to backport to 1.11 since this is a testing dep. Anyone know if we need to update
vault-testing-stepwiseas well?Inclined not to add a changelog as the motivation was for the containerd test dep, but if others feel the other updates warrant a changelog, happy to add one.
Resolves: #15639
/cc @mickael-hc