Add image digest result to remaining sample build strategies #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
release-note-none
SaschaSchwarze0
added
the
kind/feature
qu1queee
reviewed
May 28, 2021
SaschaSchwarze0
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
SaschaSchwarze0
force-pushed
the
sascha-image-digest-result
branch
from
f748625
to
e6a2cdd
Compare
SaschaSchwarze0
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
qu1queee
reviewed
May 31, 2021
qu1queee
approved these changes
May 31, 2021
|
/lgtm |
SaschaSchwarze0
force-pushed
the
sascha-image-digest-result
branch
from
e6a2cdd
to
0d4cfe8
Compare
|
Conflicts resolved. May you re-lgtm ? @qu1queee |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HeavyWombat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There were some build strategies remaining where the image digest result has not yet been provided. Doing this here:
--metadata-filefield. Thanks @qu1queee for pointing me to Add --metadata-file flag to output build metadata #2095. Also switching from master-rootless to nightly-rootless which is the same image without themasterterm.buildah imagescommand with the--formatoption to access the.Digestproperty. I spent some time to see if I can also get the image size here. Unfortunately, the.Sizeproperty of the same command is always formatted (10.3 MB instead of the bytes count) and the raw value available in the code is not exposed. As I had to run anotherbuildahcommand (afterbudandpush), I decided to consolidate all of them to run in a single container.Submitter Checklist
Release Notes