Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for build.spec.source.url #512

Merged
merged 3 commits into from
Jan 20, 2021
Merged

Add validation for build.spec.source.url #512

merged 3 commits into from
Jan 20, 2021

Commits on Jan 19, 2021

  1. Add main logic, unit test and integration test for build controller v… 

    …alidates spec.source.url

refine the main logic of build validates sourceURL

return validate error and update error

only return updateError when validate sourceURL failed

rename verify sourceURL annotation and make verifySourceURL by default

update test cases again

revert verifySourceURL

verify sourceURL by default

add unit test for validateSourceURL

return a same error when list remote repo failed

output different errors and update tests

Signed-off-by: Enrique Encalada <encalada@de.ibm.com>
    @xiujuan95 @qu1queee
    xiujuan95 authored and qu1queee committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    9bdb882 View commit details
    Browse the repository at this point in the history

  2. update vendor dependencies 

    Signed-off-by: Enrique Encalada <encalada@de.ibm.com>
    @xiujuan95 @qu1queee
    xiujuan95 authored and qu1queee committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    b073f77 View commit details
    Browse the repository at this point in the history

  3. update document 

    Change verify sourceURL by default

Signed-off-by: Enrique Encalada <encalada@de.ibm.com>
    @xiujuan95 @qu1queee
    xiujuan95 authored and qu1queee committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    9a2d98b View commit details
    Browse the repository at this point in the history