Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test break due to pytest 5.4.0 update (issue #757) #758

Merged
merged 1 commit into from Mar 13, 2020
Merged

Fix test break due to pytest 5.4.0 update (issue #757) #758

merged 1 commit into from Mar 13, 2020

Conversation

DougBurke
Copy link
Contributor

@DougBurke DougBurke commented Mar 13, 2020 •
edited

Summary

Update tests to work with the pytest 5.4.0 release. Fixes #757

Details

The pytest 5.4.0 update changed how "implicit" parameters are
passed around. See

pytest-dev/pytest#6909

for more details.

@DougBurke
Fix test break due to pytest 5.4.0 update (issue sherpa#757)
cceceeb 
The pytest 5.4.0 update changed how "implicit" parameters are
passed around. See

pytest-dev/pytest#6909

for more details.
@DougBurke
Copy link
Contributor Author

It looks like this change may be reverted in pytest, but I think it's still worth merging this PR (it is a bit less magical, if anything in pytest can be set to not be magical).

One concern I had was whether this would work with pytest prior to 5.4.0 but fortunately the travis tests include this condition, and it does.

@wmclaugh
Copy link
Contributor

@DougBurke-

Dan has reviewed and approved your fix. I note that in the meantime, pytest has already released v5.4.1 which reverts the change. Does the new release have any implications on this PR?

@DougBurke
Copy link
Contributor Author

Thanks for the quick review. I just upgraded to pytest 5.4.1 and the tests still pass, thankfully.

@wmclaugh wmclaugh merged commit f98ff97 into sherpa:master Mar 13, 2020
@DougBurke DougBurke deleted the fix-pytest-540-udate branch March 13, 2020 21:54
Marie-Terrell pushed a commit that referenced this pull request Apr 29, 2020
@wmclaugh @Marie-Terrell
Merge #758 (DougBurke) - Fix test break due to pytest 5.4.0 update (i…
b930987 
…ssue #757)

Fix test break due to pytest 5.4.0 update (issue #757)
@wmclaugh wmclaugh added this to the 4.12.1 milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtnguyen2 dtnguyen2 dtnguyen2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.12.1
Development

Successfully merging this pull request may close these issues.

some of our tests now fail due to pytest=5.4.0
3 participants
@DougBurke @wmclaugh @dtnguyen2