Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating docs in preparation for 0.7 #317

Merged
merged 3 commits into from Jan 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

See the [upgrading guide][] for more detailed information about
modifying code to account for new releases.

[upgrading guide]: https://docs.rs/snafu/*/snafu/guide/upgrading/index.html

## [0.7.0] - XXXX-XX-XX

### Added
Expand Down
13 changes: 7 additions & 6 deletions src/Snafu.md
Expand Up @@ -73,11 +73,12 @@ fn main() {

### Changing the context selector suffix

When context selectors are generated, they have the suffix `Snafu`
added by default. If you'd prefer a different suffix, such as `Ctx` or
`Context`, you can specify that with
`#[snafu(context(suffix(SomeIdentifier)))]`. If you'd like to disable
the suffix entirely, you can use `#[snafu(context(suffix(false)))]`.
When context selectors are generated, any `Error` suffix is removed
and the suffix `Snafu` is added by default. If you'd prefer a
different suffix, such as `Ctx` or `Context`, you can specify that
with `#[snafu(context(suffix(SomeIdentifier)))]`. If you'd like to
disable the suffix entirely, you can use
`#[snafu(context(suffix(false)))]`.

**Example**

Expand All @@ -86,7 +87,7 @@ the suffix entirely, you can use `#[snafu(context(suffix(false)))]`.
#
#[derive(Debug, Snafu)]
enum Error {
UsesTheDefaultSuffix,
UsesTheDefaultSuffixError,

#[snafu(context(suffix(Ctx)))]
HasAnotherSuffix,
Expand Down
60 changes: 54 additions & 6 deletions src/guide/upgrading.md
Expand Up @@ -9,6 +9,12 @@

## Version 0.6 → 0.7

Upgrading should be a tedious but straightforward process. To assist
upgrading your code, you can use the [snafu-upgrade-assistant], which
attempts to automatically update breaking changes.

[snafu-upgrade-assistant]: https://github.com/shepmaster/snafu-upgrade-assistant
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, wish I knew about this tool earlier.


### Context selector names have changed

Previously, context selector names for enum errors exactly matched
Expand All @@ -17,13 +23,55 @@ confusion for people new to SNAFU. It was also inconsistent with
context selector names for struct errors.

Now, context selectors for both enum and struct errors use the `Snafu`
suffix.
suffix. Any existing `Error` suffix is removed before `Snafu` is
added.

Upgrading should be a tedious but straightforward process. To assist
upgrading your code, you can use the [snafu-upgrade-assistant], which
attempts to locate all of your context selectors and rename them.
#### Before

[snafu-upgrade-assistant]: https://github.com/shepmaster/snafu-upgrade-assistant
```rust,ignore
#[derive(Debug, Snafu)]
struct StructError;
#[derive(Debug, Snafu)]
enum EnumError {
VariantError,
}
ensure!(false, StructContext);
ensure!(false, VariantError);
```

#### After

```rust,ignore
#[derive(Debug, Snafu)]
struct StructError;
#[derive(Debug, Snafu)]
enum EnumError {
VariantError,
}
ensure!(false, StructSnafu);
ensure!(false, VariantSnafu);
```

### `with_context` takes an argument

`ResultExt::with_context`, `TryFutureExt::with_context`, and
`TryStreamExt::with_context` now pass the error into the closure.

#### Before

```rust,ignore
some_result.with_context(|| ContextSelector);
```

#### After

```rust,ignore
some_result.with_context(|_| ContextSelector);
```

### String attribute parsing is no longer supported

Expand Down Expand Up @@ -75,7 +123,7 @@ The `backtrace-crate` feature flag has been renamed to
`backtraces-impl-backtrace-crate`. The backtrace returned by
`ErrorCompat::backtrace` is now the `backtrace::Backtrace` type when
this flag is enabled, so the implementation of `AsRef` has been
removed..
removed.

### Futures

Expand Down
6 changes: 3 additions & 3 deletions src/lib.rs
Expand Up @@ -20,7 +20,7 @@
#![cfg_attr(feature = "futures", doc = " - [`Futures`](futures::TryFutureExt)")]
#![cfg_attr(feature = "futures", doc = " - [`Streams`](futures::TryStreamExt)")]
//! - Suitable for libraries and applications
//! - `no-std` compatibility
//! - `no_std` compatibility
//! - Generic types and lifetimes
//!
//! For detailed information, please see the [user's guide](guide).
Expand Down Expand Up @@ -76,7 +76,7 @@
//! that occurs, it's time to create your own error type by deriving
//! [`Snafu`][]!
//!
//! ### Structs
//! ### Struct style
//!
//! SNAFU will read your error struct definition and create a *context
//! selector* type (called `InvalidIdSnafu` in this example). These
Expand Down Expand Up @@ -117,7 +117,7 @@
//! }
//! ```
//!
//! ### Enums
//! ### Enum style
//!
//! While error structs are good for constrained cases, they don't
//! allow for reporting multiple possible kinds of errors at one
Expand Down