Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make manifest type match readme doc #282

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

m1heng
Copy link
Contributor

@m1heng m1heng commented Dec 30, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: #284

Description

According to READ.ME, "return_ anything as long as it's serialisable by JSON.stringify".
But when I started ts-check in my config file, I found Manifest type is Record<string, string> which is not quite fit into READ.ME.

Sorry, something went wrong.

@shellscape shellscape merged commit 280bce1 into shellscape:master Jan 11, 2022
@m1heng m1heng deleted the fix/manifest-type branch January 12, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants