chore: add support for v0.11+ #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfischer
force-pushed
the
chore-support-v0-11
branch
from
9e18aba
to
3bb7cbf
Compare
Current coverage is 89.28% (diff: 100%)@@ master #81 diff @@
==========================================
Files 2 2
Lines 26 28 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 23 25 +2
Misses 3 3
Partials 0 0
|
nfischer
force-pushed
the
chore-support-v0-11
branch
from
3bb7cbf
to
57d22f7
Compare
| import objAssign from 'es6-object-assign'; | ||
| objAssign.polyfill(); // modifies the global object | ||
|
|
||
| const pathExistsSync = (filePath) => { |
There was a problem hiding this comment.
I know it's a tiny amount of code, but Sindre did write path-exists for this. If nothing else, it is one less utility for us to manage.
There was a problem hiding this comment.
We were originally using that, but it only works on node v4+ so I had to switch to a different implementation. This is based off this comment on a thread regarding the deprecation.
|
Weird, travis couldn't find commits for 2 jobs and one test timed out. I've restarted them, we'll see what happens. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is too much of a maintenance burden, and it lets us take advantage of shx from within shelljs, which I think is a big win.
If I missed anything, let me know.
This blocks shelljs/shelljs#525