chore(npm): remove lockfile #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfischer
force-pushed
the
chore-no-lockfile
branch
from
f9b0518
to
3ff1f67
Compare
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 88 88
=====================================
Hits 88 88Continue to review full report at Codecov.
|
This removes the package-lock, since `npm install` modifies the lockfile (due to a disagreement between npm@5 and npm@6). We're removing it for ShellJS, and removing it here for consistency. See shelljs/shelljs#893
nfischer
force-pushed
the
chore-no-lockfile
branch
from
3ff1f67
to
ae6dbb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the package-lock, since
npm installmodifies the lockfile(due to a disagreement between npm@5 and npm@6). We're removing it for
ShellJS, and removing it here for consistency.
See shelljs/shelljs#893