chore: fix issues with nyc and mocha #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes 2 issues, both of which are vaguely related to babel transpiling during tests: * The new mocha version uses the `--require` flag instead of `--compilers`. * nyc 12.0.0 causes mysterious "Transformation errors" with transpiling during tests. This PR addresses the first issue by switching the flag as required. This PR addresses the second issue by downgrading nyc, as it's not clear if nyc or our project is the real culprit. Fixes #144
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 75 75
=====================================
Hits 75 75Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 issues, both of which are vaguely related to babel
transpiling during tests:
--requireflag instead of--compilers.during tests.
This PR addresses the first issue by switching the flag as required.
This PR addresses the second issue by downgrading nyc, as v11 is the
last release which supports node v4.
Fixes #144