feat(version): support --version flag #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the `--version` CLI flag. This outputs the version number for both shx and the bundled version of ShellJS. This adds a test to strictly assert the output format, so that this can be reliably parsed if necessary. This also reorganizes the structure of some test cases (without changing their logic). Fixes #111 Test: case: 'supports --version'
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 22 25 +3
=====================================
+ Hits 22 25 +3
Continue to review full report at Codecov.
|
freitagbr
approved these changes
Jun 20, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
--versionCLI flag. This outputs the versionnumber for both shx and the bundled version of ShellJS. This adds a test
to strictly assert the output format, so that this can be reliably
parsed if necessary.
This also reorganizes the structure of some test cases (without changing
their logic).
Lastly, this changes the file modes for 2 files. These were previously
unnecessarily executable.
Fixes #111
Test: case: 'supports --version'