Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence potentially upcoming circular dependency warning #973

Merged
merged 1 commit into from Oct 20, 2019

Commits on Oct 18, 2019

  1. Silence potentially upcoming circular dependency warning

    Node.js is currently considering printing a warning when a non-existent
    property of `module.exports` is accessed while in a circular `require()`
    dependency, in order to make it easier to catch issues with circular
    dependencies.
    
    In order to avoid printing these warnings for shelljs, checking for the
    property’s existence rather than its truthiness suffices.
    
    Refs: nodejs/node#29935
    addaleax committed Oct 18, 2019
    Copy the full SHA
    a6bb08e View commit details
    Browse the repository at this point in the history