Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(exec): document security concerns #950

Merged
merged 1 commit into from Jun 26, 2019
Merged

docs(exec): document security concerns #950

merged 1 commit into from Jun 26, 2019

Conversation

nfischer
Copy link
Member

@nfischer nfischer commented Jun 26, 2019 •
edited

No change to logic.

This adds documentation about shell.exec()'s inherent vulnerability to
command injection and links to a more detailed security notice.

Issue #103, #143, #495, #765, #766, #810, #842, #938, #945

@nfischer nfischer added docs exec Issues specific to the shell.exec() API security labels Jun 26, 2019
@nfischer
docs(exec): document security concerns
e63899d 
No change to logic.

This adds documentation about `shell.exec()`'s inherent vulnerability to
command injection and links to a more detailed security notice.

Issue #103, #143, #495, #765, #766, #810, #842, #938, #945
@codecov-io
Copy link

Codecov Report

Merging #950 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #950   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files          34       34           
  Lines        1290     1290           
=======================================
  Hits         1255     1255           
  Misses         35       35
Impacted Files Coverage Δ
src/exec.js 97.1% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619d234...e63899d. Read the comment docs.

@nfischer nfischer merged commit 68c3822 into master Jun 26, 2019
nfischer added a commit that referenced this pull request Jun 26, 2019
@nfischer
docs(exec): minor wording changes on security doc
c43642b 
This is a follow-up to #950, to emphasize the message.
@nfischer nfischer mentioned this pull request Jun 26, 2019
Merged
@nfischer
Copy link
Member Author

I realized "avoid command execution" should be "avoid command injection" - sent out #951 to address this.

@nfischer nfischer deleted the exec-security-docs branch June 26, 2019 15:24
nfischer added a commit that referenced this pull request Jun 26, 2019
@nfischer
docs(exec): minor wording changes on security doc (#951)
7aa8ce4 
This is a follow-up to #950, to emphasize the message.
@nfischer nfischer mentioned this pull request Jun 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs exec Issues specific to the shell.exec() API security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nfischer @codecov-io