Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(node): add v10 and v11 to CI #921

Merged
merged 1 commit into from Dec 3, 2018
Merged

chore(node): add v10 and v11 to CI #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -5,6 +5,8 @@ node_js:
- 7
- 8
- 9
- 10
- 11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still recommend node (fail early and also auto update when 12 comes out - otherwise we might miss the release of 12 and there could be breaking changes so someone has to update the CI config again when a new major version is released).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look. You raise a good point, but node isn't really the answer: in that case we would test 12 but miss 11, which is not what we want. Even if we didn't test unsupported node releases, we'd still hit this problem between 12 & 13 (at which point both would be supported).

IMO auto updating is not desirable, because a breaking change in 12 would cause CI to fail suddenly on master and CI would reject unrelated PRs.

Let me know if you see a better path forward.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want to test 11 when 12 is released as it will reach its EOL then and 13 will be released. See https://github.com/nodejs/Release/blob/master/schedule.png

But I guess we can currently keep it as is. Both ways / solutions have their advantages and disadvantages.


os:
- linux
Expand Down
2 changes: 2 additions & 0 deletions appveyor.yml
View file
Open in desktop
@@ -1,5 +1,7 @@
environment:
matrix:
- nodejs_version: '11'
- nodejs_version: '10'
- nodejs_version: '9'
- nodejs_version: '8'
- nodejs_version: '7'
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-node-support.js
View file
Open in desktop
Expand Up @@ -9,7 +9,7 @@ var shell = require('..');

// This is the authoritative list of supported node versions.
var MIN_NODE_VERSION = 6;
var MAX_NODE_VERSION = 9;
var MAX_NODE_VERSION = 11;

function checkReadme(minNodeVersion) {
var start = '<!-- start minVersion -->';
Expand Down
2 changes: 0 additions & 2 deletions src/exec-child.js
View file
Open in desktop
Expand Up @@ -28,8 +28,6 @@ function isMaxBufferError(err) {
// >= v10
// RangeError [ERR_CHILD_PROCESS_STDIO_MAXBUFFER]: stdout maxBuffer length
// exceeded
// TODO(nfischer): remove when we add v10 CI (Github issue #856).
/* istanbul ignore next */
return true;
}
return false;
Expand Down