Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(exec): consistent error message for maxBuffer #919

Merged
merged 2 commits into from Dec 3, 2018
Merged

fix(exec): consistent error message for maxBuffer #919

merged 2 commits into from Dec 3, 2018

Commits on Dec 3, 2018

  1. fix(exec): consistent error message for maxBuffer 

    This explicitly checks for maxBuffer errors in exec-child.js and
provides a consistent error message. This modifies the test to verify
this.

This also supports the change in Node v10, which emits this as a
RangeError instead of a regular Error.

Although the error message is now explicit, this is not part of our API,
since it's just tacked onto the end of exec's stderr.

Fixes #915
    @nfischer
    nfischer committed Dec 3, 2018
    Copy the full SHA
    c892ddf View commit details
    Browse the repository at this point in the history

  2. Remove debugging log, ignore uncovered lines

    @nfischer
    nfischer committed Dec 3, 2018
    Copy the full SHA
    5b4417b View commit details
    Browse the repository at this point in the history